Messages in this thread | | | From | Andrey Konovalov <> | Date | Wed, 6 Oct 2021 13:57:28 +0200 | Subject | Re: [PATCH] kasan: Always respect CONFIG_KASAN_STACK |
| |
On Wed, Oct 6, 2021 at 4:43 AM Nathan Chancellor <nathan@kernel.org> wrote: > > > This part of code always looked weird to me. > > > > Shouldn't we be able to pull all these options out of the else section? > > > > Then, the code structure would make sense: first, try applying > > KASAN_SHADOW_OFFSET; if failed, use CFLAGS_KASAN_MINIMAL; and then try > > applying all these options one by one. > > Prior to commit 1a69e7ce8391 ("kasan/Makefile: support LLVM style asan > parameters"), all the flags were run under one cc-option, meaning that > if $(KASAN_SHADOW_OFFSET) was not set, the whole call would fail. > However, after that commit, it is possible to do this but I was not sure > if that was intentional so I went for the minimal fix.
Ack. Filed https://bugzilla.kernel.org/show_bug.cgi?id=214629 for the rest.
Thanks!
| |