lkml.org 
[lkml]   [2021]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v4 2/7] dt-bindings: memory: lpddr2: Convert to schema
Date
On 06/10/2021 01:00, Dmitry Osipenko wrote:
> Convert LPDDR2 binding to schema. I removed obsolete ti,jedec-lpddr2-*
> compatibles since they were never used by device-trees and by the code.
>
> Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> .../memory-controllers/ddr/jedec,lpddr2.yaml | 195 ++++++++++++++++++
> .../memory-controllers/ddr/lpddr2.txt | 102 ---------
> 2 files changed, 195 insertions(+), 102 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml
> delete mode 100644 Documentation/devicetree/bindings/memory-controllers/ddr/lpddr2.txt
>
> diff --git a/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml b/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml
> new file mode 100644
> index 000000000000..d99ccad54938
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr2.yaml
> @@ -0,0 +1,195 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/memory-controllers/ddr/jedec,lpddr2.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LPDDR2 SDRAM compliant to JEDEC JESD209-2
> +
> +maintainers:
> + - Krzysztof Kozlowski <krzk@kernel.org>

My Canonical address please, so:
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - Elpida,ECB240ABACN
> + - enum:
> + - jedec,lpddr2-s4
> + - items:
> + - enum:
> + - jedec,lpddr2-s2
> + - items:
> + - enum:
> + - jedec,lpddr2-nvm
> +
> + density:
> + description: |
> + Density in megabits of SDRAM chip. Obtained from device datasheet.

You need here a type/ref, so uint32.

> + enum:
> + - 64
> + - 128
> + - 256
> + - 512
> + - 1024
> + - 2048
> + - 4096
> + - 8192
> + - 16384
> + - 32768
> +
> + io-width:
> + description: |
> + IO bus width in bits of SDRAM chip. Obtained from device datasheet.

You need here a type/ref, so uint32.

> + enum:
> + - 32
> + - 16
> + - 8
> +
> + tRRD-min-tck:
> + maximum: 16

Here and further type is needed.


> + description: |
> + Active bank a to active bank b in terms of number of clock cycles.
> + Obtained from device datasheet.
> +
> + tWTR-min-tck:
> + maximum: 16
> + description: |
> + Internal WRITE-to-READ command delay in terms of number of clock cycles.
> + Obtained from device datasheet.
> +

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2021-10-06 12:57    [W:0.121 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site