Messages in this thread | | | Date | Wed, 6 Oct 2021 15:57:56 +0530 | From | Vinod Koul <> | Subject | Re: [Freedreno] [PATCH 04/11] drm/msm/disp/dpu1: Add DSC support in RM |
| |
On 02-08-21, 16:24, abhinavk@codeaurora.org wrote: > On 2021-07-14 23:51, Vinod Koul wrote:
> > @@ -476,6 +498,9 @@ static int _dpu_rm_reserve_intf( > > } > > > > global_state->intf_to_enc_id[idx] = enc_id; > > + > > + global_state->dsc_to_enc_id[0] = enc_id; > > + global_state->dsc_to_enc_id[1] = enc_id; > > return 0; > > } > agree with dmitry again here, why are DSCs being reserved in the > _dpu_rm_reserve_intf function? > First, for clarity, they should be in a function of their own. > Allocating the DSCs has to also account for the PP availability of that DSC > and other factors need to > be considered as well. > I suggest checking _sde_rm_reserve_dsc() from downstream to improve the DSC > reservation logic.
Yes I have moved to a new helper _dpu_rm_reserve_dsc(). PP availability is already checked so no need to do that here as well
-- ~Vinod
| |