Messages in this thread | | | From | Shakeel Butt <> | Date | Tue, 5 Oct 2021 22:20:45 -0700 | Subject | Re: [PATCH v2] mm/memcg: Remove obsolete memcg_free_kmem() |
| |
On Tue, Oct 5, 2021 at 1:25 PM Waiman Long <longman@redhat.com> wrote: > > Since commit d648bcc7fe65 ("mm: kmem: make memcg_kmem_enabled() > irreversible"), the only thing memcg_free_kmem() does is to call > memcg_offline_kmem() when the memcg is still online which can happen when > online_css() fails due to -ENOMEM. However, the name memcg_free_kmem() > is confusing and it is more clear and straight forward to call > memcg_offline_kmem() directly from mem_cgroup_css_free(). > > Suggested-by: Roman Gushchin <guro@fb.com> > Signed-off-by: Waiman Long <longman@redhat.com>
Reviewed-by: Shakeel Butt <shakeelb@google.com>
| |