lkml.org 
[lkml]   [2021]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [net-next PATCH 01/13] drivers: net: phy: at803x: fix resume for QCA8327 phy
    On Thu, Oct 07, 2021 at 12:35:51AM +0200, Ansuel Smith wrote:
    > >From Documentation phy resume triggers phy reset and restart
    > auto-negotiation. Add a dedicated function to wait reset to finish as
    > it was notice a regression where port sometime are not reliable after a
    > suspend/resume session. The reset wait logic is copied from phy_poll_reset.
    > Add dedicated suspend function to use genphy_suspend only with QCA8337
    > phy and set only additional debug settings for QCA8327. With more test
    > it was reported that QCA8327 doesn't proprely support this mode and
    > using this cause the unreliability of the switch ports, especially the
    > malfunction of the port0.
    >
    > Fixes: 52a6cdbe43a3 ("net: phy: at803x: add resume/suspend function to qca83xx phy")

    Please base it on net, since it is a fix.

    > -#define AT803X_DEBUG_REG_3D 0x3D
    > +#define AT803X_DEBUG_REG_GREEN 0x3D

    Fixes are supposed to be minimal. So i would not include the rename of
    3D to GREEN in the fix. Do that in a patch for net-next.

    Andrew

    \
     
     \ /
      Last update: 2021-10-07 02:05    [W:4.390 / U:0.660 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site