Messages in this thread Patch in this message | | | Date | Tue, 05 Oct 2021 14:12:16 -0000 | From | "tip-bot2 for Sebastian Andrzej Siewior" <> | Subject | [tip: sched/core] sched: Switch wait_task_inactive to HRTIMER_MODE_REL_HARD |
| |
The following commit has been merged into the sched/core branch of tip:
Commit-ID: c33627e9a1143afb988fb98d917c4a2faa16f9d9 Gitweb: https://git.kernel.org/tip/c33627e9a1143afb988fb98d917c4a2faa16f9d9 Author: Sebastian Andrzej Siewior <bigeasy@linutronix.de> AuthorDate: Thu, 26 Aug 2021 19:04:08 +02:00 Committer: Peter Zijlstra <peterz@infradead.org> CommitterDate: Tue, 05 Oct 2021 15:51:32 +02:00
sched: Switch wait_task_inactive to HRTIMER_MODE_REL_HARD
With PREEMPT_RT enabled all hrtimers callbacks will be invoked in softirq mode unless they are explicitly marked as HRTIMER_MODE_HARD. During boot kthread_bind() is used for the creation of per-CPU threads and then hangs in wait_task_inactive() if the ksoftirqd is not yet up and running. The hang disappeared since commit 26c7295be0c5e ("kthread: Do not preempt current task if it is going to call schedule()")
but enabling function trace on boot reliably leads to the freeze on boot behaviour again. The timer in wait_task_inactive() can not be directly used by a user interface to abuse it and create a mass wake up of several tasks at the same time leading to long sections with disabled interrupts. Therefore it is safe to make the timer HRTIMER_MODE_REL_HARD.
Switch the timer to HRTIMER_MODE_REL_HARD.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Link: https://lkml.kernel.org/r/20210826170408.vm7rlj7odslshwch@linutronix.de --- kernel/sched/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 1bba412..2672694 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -3251,7 +3251,7 @@ unsigned long wait_task_inactive(struct task_struct *p, unsigned int match_state ktime_t to = NSEC_PER_SEC / HZ; set_current_state(TASK_UNINTERRUPTIBLE); - schedule_hrtimeout(&to, HRTIMER_MODE_REL); + schedule_hrtimeout(&to, HRTIMER_MODE_REL_HARD); continue; }
| |