lkml.org 
[lkml]   [2021]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] sched/fair: Scale wakeup granularity relative to nr_running
On Tue, Oct 05, 2021 at 12:36:22PM +0200 Peter Zijlstra wrote:
> On Thu, Sep 23, 2021 at 08:24:03AM -0400, Phil Auld wrote:
>
> > It's capped at 8 cpus, which is pretty easy to reach these days, so the
> > values don't get too large. That scaling is almost a no-op these days.
>
> https://lkml.kernel.org/r/YVwdrh5pg0zSv2/b@hirez.programming.kicks-ass.net
>
> Ooh, hey, we already fixed that :-)
>

Thanks Peter.

I'm always a little behind upstream (nature of the job :)

That link leads to a message Id not found. But from what I can see the
code that takes the min of online cpus and 8 is still present.


> So the reasoning there is that if the values get too big, interactiviy
> get *really* bad, but if you go from say 1 to 4 CPUs, interactivity can
> improve due to being able to run on other CPUs.
>
> At 8 CPUs we end up at 6ms*4=24ms, which is already pretty terrible.
>

And actually you mention the same thing later on. Most systems, even
desktops, have 8+ cpus these days so the scaling is mostly not doing
anything except multiplying by 4, right? So no-op was not the right
way to describe it maybe. But it's not getting bigger with larger
numbers of cpus beyond a pretty commonly reached limit.


Cheers,
Phil

--

\
 
 \ /
  Last update: 2021-10-05 16:14    [W:0.083 / U:0.660 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site