Messages in this thread | | | Date | Tue, 5 Oct 2021 07:02:25 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH v7 13/24] wfx: add hif_tx*.c/hif_tx*.h |
| |
On Tue, 05 Oct 2021 09:12:27 +0300 Kalle Valo wrote: > >> I didn't know it was mandatory to prefix all the functions with the > >> same prefix. > > I don't know either if this is mandatory or not, for example I do not > have any recollection what Linus and other maintainers think of this. I > just personally think it's good practise to use driver prefix ("wfx_") > in all non-static functions.
I'd even say all functions. The prefixes are usually 3 chars, it's no hassle to add and makes reading the code and looking at stack traces much more intuitive for people who are not intimately familiar with the code.
| |