lkml.org 
[lkml]   [2021]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.14 33/40] scsi: ses: Fix unsigned comparison with less than zero
    Date
    From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

    [ Upstream commit dd689ed5aa905daf4ba4c99319a52aad6ea0a796 ]

    Fix the following coccicheck warning:

    ./drivers/scsi/ses.c:137:10-16: WARNING: Unsigned expression compared
    with zero: result > 0.

    Link: https://lore.kernel.org/r/1632477113-90378-1-git-send-email-jiapeng.chong@linux.alibaba.com
    Reported-by: Abaci Robot <abaci@linux.alibaba.com>
    Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/ses.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/scsi/ses.c b/drivers/scsi/ses.c
    index c2afba2a5414..d155a7329b07 100644
    --- a/drivers/scsi/ses.c
    +++ b/drivers/scsi/ses.c
    @@ -111,7 +111,7 @@ static int ses_recv_diag(struct scsi_device *sdev, int page_code,
    static int ses_send_diag(struct scsi_device *sdev, int page_code,
    void *buf, int bufflen)
    {
    - u32 result;
    + int result;

    unsigned char cmd[] = {
    SEND_DIAGNOSTIC,
    --
    2.33.0
    \
     
     \ /
      Last update: 2021-10-05 15:53    [W:2.084 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site