Messages in this thread | | | Date | Tue, 5 Oct 2021 13:37:15 +0300 | From | Heikki Krogerus <> | Subject | Re: [PATCH] usb: typec: STUSB160X should select REGMAP_I2C |
| |
On Mon, Oct 04, 2021 at 04:21:03PM -0700, Randy Dunlap wrote: > REGMAP_I2C is not a user visible kconfig symbol so driver configs > should not "depend on" it. They should depend on I2C and then > select REGMAP_I2C. > > If this worked, it was only because some other driver had set/enabled > REGMAP_I2C. > > Fixes: da0cb6310094 ("usb: typec: add support for STUSB160x Type-C controller family") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com> > Cc: Amelie Delaunay <amelie.delaunay@st.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: linux-usb@vger.kernel.org
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> --- > drivers/usb/typec/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- lnx-515-rc4.orig/drivers/usb/typec/Kconfig > +++ lnx-515-rc4/drivers/usb/typec/Kconfig > @@ -65,9 +65,9 @@ config TYPEC_HD3SS3220 > > config TYPEC_STUSB160X > tristate "STMicroelectronics STUSB160x Type-C controller driver" > - depends on I2C > - depends on REGMAP_I2C > depends on USB_ROLE_SWITCH || !USB_ROLE_SWITCH > + depends on I2C > + select REGMAP_I2C > help > Say Y or M here if your system has STMicroelectronics STUSB160x > Type-C port controller.
-- heikki
| |