lkml.org 
[lkml]   [2021]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RESEND PATCH] aio: Add support for the POLLFREE
Date
Hi, Ramji,

Ramji Jiyani <ramjiyani@google.com> writes:

> Hi Jeff:
>
> On Tue, Oct 5, 2021 at 12:33 PM Jeff Moyer <jmoyer@redhat.com> wrote:
>>
>> Hi, Ramji,
>>
>> Thanks for the explanation of the use after free. I went ahead and
>> ran the patch through the libaio test suite and it passed.
>>
>
> Thanks for taking time to test and providing feedback.
>
>> > -#define POLLFREE (__force __poll_t)0x4000 /* currently only for epoll */
>> > +#define POLLFREE ((__force __poll_t)0x4000)
>>
>> You added parenthesis, here, and I'm not sure if that's a necessary part
>> of this patch.
>
> I added parenthesis to silence the checkpatch script. Should I just ignore it?
> I'll send v2 with the change, if it is required.

None of the other #defines in that file use parens, so it would, at the
very least, be inconsistent. I would leave the the parens out.

Cheers,
Jeff

\
 
 \ /
  Last update: 2021-10-05 21:55    [W:0.141 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site