lkml.org 
[lkml]   [2021]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v1] KVM: isolation: retain initial mask for kthread VM worker
From
On 05/10/21 15:21, Marcelo Tosatti wrote:
>> The QEMU I/O thread is not hogging the CPU 100% of the time, and
>> therefore the nx-recovery thread should be able to run on that CPU.
>
> 1) The cpumask of the parent thread is not inherited
>
> set_cpus_allowed_ptr(task, housekeeping_cpumask(HK_FLAG_KTHREAD));
>
> On __kthread_create_on_node should fail (because its cgroup, the one
> inherited from QEMU, contains only isolated CPUs).
>
> (The QEMU I/O thread runs on an isolated CPU, and is moved by libvirt
> to HK-cgroup as mentioned before).

Ok, that's the part that I missed. So the core issue is that libvirt
moves the I/O thread out of the isolated-CPU cgroup too late? This in
turn is because libvirt gets access to the QEMU monitor too late (the
KVM file descriptor is created when QEMU processes the command line).

Paolo

\
 
 \ /
  Last update: 2021-10-05 19:16    [W:0.067 / U:0.980 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site