lkml.org 
[lkml]   [2021]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] dt-bindings: cpufreq: cpufreq-qcom-hw: Convert to YAML bindings
    Date
    On Mon, 04 Oct 2021 10:13:17 +0530, Manivannan Sadhasivam wrote:
    > Convert Qualcomm cpufreq devicetree binding to YAML.
    >
    > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
    > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
    > Reviewed-by: Rob Herring <robh@kernel.org>
    > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
    > ---
    >
    > I've taken this patch (again) from the cpufreq series by AngeloGioacchino.
    > Addressed the comment by Rob and Bjorn on making the "reg-names" property
    > optional as in the txt version.
    >
    > .../bindings/cpufreq/cpufreq-qcom-hw.txt | 172 ---------------
    > .../bindings/cpufreq/cpufreq-qcom-hw.yaml | 203 ++++++++++++++++++
    > 2 files changed, 203 insertions(+), 172 deletions(-)
    > delete mode 100644 Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.txt
    > create mode 100644 Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
    >

    My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
    on your patch (DT_CHECKER_FLAGS is new in v5.13):

    yamllint warnings/errors:

    dtschema/dtc warnings/errors:
    /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml: properties:reg: {'minItems': 2, 'maxItems': 3, 'items': [{'description': 'Frequency domain 0 register region'}, {'description': 'Frequency domain 1 register region'}, {'description': 'Frequency domain 2 register region'}]} should not be valid under {'required': ['maxItems']}
    hint: "maxItems" is not needed with an "items" list
    from schema $id: http://devicetree.org/meta-schemas/items.yaml#
    /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml: properties:reg-names: {'minItems': 2, 'maxItems': 3, 'items': [{'const': 'freq-domain0'}, {'const': 'freq-domain1'}, {'const': 'freq-domain2'}]} should not be valid under {'required': ['maxItems']}
    hint: "maxItems" is not needed with an "items" list
    from schema $id: http://devicetree.org/meta-schemas/items.yaml#
    /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml: ignoring, error in schema: properties: reg
    warning: no schema found in file: ./Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
    Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.example.dt.yaml:0:0: /example-0/soc/cpufreq@17d43000: failed to match any schema with compatible: ['qcom,cpufreq-hw']

    doc reference errors (make refcheckdocs):

    See https://patchwork.ozlabs.org/patch/1535939

    This check can fail if there are any dependencies. The base for a patch
    series is generally the most recent rc1.

    If you already ran 'make dt_binding_check' and didn't see the above
    error(s), then make sure 'yamllint' is installed and dt-schema is up to
    date:

    pip3 install dtschema --upgrade

    Please check and re-submit.

    \
     
     \ /
      Last update: 2021-10-04 14:22    [W:4.289 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site