lkml.org 
[lkml]   [2021]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] scsi: fcoe:Use kmemdup() rather than kmalloc+memcpy
Date
Replace calls to kmalloc followed by a memcpy with a direct 
call to kmemdup.

Signed-off-by: Kai Song <songkai01@inspur.com>
---
drivers/scsi/fcoe/fcoe_ctlr.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/fcoe/fcoe_ctlr.c b/drivers/scsi/fcoe/fcoe_ctlr.c
index 1756a0ac6f08..37df848e7545 100644
--- a/drivers/scsi/fcoe/fcoe_ctlr.c
+++ b/drivers/scsi/fcoe/fcoe_ctlr.c
@@ -1045,11 +1045,10 @@ static void fcoe_ctlr_recv_adv(struct fcoe_ctlr *fip, struct sk_buff *skb)
if (fip->fcf_count >= FCOE_CTLR_FCF_LIMIT)
goto out;

- fcf = kmalloc(sizeof(*fcf), GFP_ATOMIC);
+ fcf = kmemdup(&new, sizeof(*fcf), GFP_ATOMIC);
if (!fcf)
goto out;

- memcpy(fcf, &new, sizeof(new));
fcf->fip = fip;
rc = fcoe_sysfs_fcf_add(fcf);
if (rc) {
--
2.27.0
\
 
 \ /
  Last update: 2021-10-04 08:42    [W:0.102 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site