Messages in this thread | | | Date | Mon, 4 Oct 2021 17:50:46 -0700 | From | Kees Cook <> | Subject | Re: [PATCH 05/10] riscv: remove Kconfig check for GCC version for ARCH_RV64I |
| |
On Mon, Oct 04, 2021 at 05:40:42PM -0700, Palmer Dabbelt wrote: > On Mon, 13 Sep 2021 09:23:45 PDT (-0700), keescook@chromium.org wrote: > > On Fri, Sep 10, 2021 at 04:40:42PM -0700, Nick Desaulniers wrote: > > > The minimum supported version of GCC is now 5.1. The check wasn't > > > correct as written anyways since GCC_VERSION is 0 when CC=clang. > > > > > > Cc: Paul Walmsley <paul.walmsley@sifive.com> > > > Cc: Palmer Dabbelt <palmer@dabbelt.com> > > > Cc: Albert Ou <aou@eecs.berkeley.edu> > > > Cc: linux-riscv@lists.infradead.org > > > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> > > > > Yeah, good catch for Clang too. > > > > Reviewed-by: Kees Cook <keescook@chromium.org> > > Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com> > Acked-by: Palmer Dabbelt <palmerdabbelt@google.com> > > Only this patch ended up in my inbox. Where you guys planning on keeping > this whole series together, or did you want me to pick this for the RISC-V > tree?
Linus already merged this series (see d20758951f8f28c0ee1b2a8a6bb8189858083895)
-- Kees Cook
| |