lkml.org 
[lkml]   [2021]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 05/10] riscv: remove Kconfig check for GCC version for ARCH_RV64I
    From
    On Mon, 13 Sep 2021 09:23:45 PDT (-0700), keescook@chromium.org wrote:
    > On Fri, Sep 10, 2021 at 04:40:42PM -0700, Nick Desaulniers wrote:
    >> The minimum supported version of GCC is now 5.1. The check wasn't
    >> correct as written anyways since GCC_VERSION is 0 when CC=clang.
    >>
    >> Cc: Paul Walmsley <paul.walmsley@sifive.com>
    >> Cc: Palmer Dabbelt <palmer@dabbelt.com>
    >> Cc: Albert Ou <aou@eecs.berkeley.edu>
    >> Cc: linux-riscv@lists.infradead.org
    >> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
    >
    > Yeah, good catch for Clang too.
    >
    > Reviewed-by: Kees Cook <keescook@chromium.org>

    Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com>
    Acked-by: Palmer Dabbelt <palmerdabbelt@google.com>

    Only this patch ended up in my inbox. Where you guys planning on
    keeping this whole series together, or did you want me to pick this for
    the RISC-V tree?

    \
     
     \ /
      Last update: 2021-10-05 02:41    [W:4.487 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site