Messages in this thread | | | Date | Mon, 4 Oct 2021 16:38:08 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH net-next v2 1/5] devlink: Reduce struct devlink exposure |
| |
On Sun, 3 Oct 2021 21:12:02 +0300 Leon Romanovsky wrote: > From: Leon Romanovsky <leonro@nvidia.com> > > The declaration of struct devlink in general header provokes the > situation where internal fields can be accidentally used by the driver > authors. In order to reduce such possible situations, let's reduce the > namespace exposure of struct devlink. > > Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
100% subjective but every time I decided to hide a structure definition like this I came to regret it later. The fact there is only one minor infraction in drivers poking at members seems to prove this is not in fact needed.
| |