Messages in this thread | | | From | Jonathan Corbet <> | Subject | Re: [PATCH v4] docs: Explain the desired position of function attributes | Date | Mon, 04 Oct 2021 17:09:18 -0600 |
| |
Kees Cook <keescook@chromium.org> writes:
> While discussing how to format the addition of various function > attributes, some "unwritten rules" of ordering surfaced[1]. Capture as > close as possible to Linus's preferences for future reference. > > (Though I note the dissent voiced by Joe Perches, Alexey Dobriyan, and > others that would prefer all attributes live on a separate leading line.) > > [1] https://lore.kernel.org/mm-commits/CAHk-=wiOCLRny5aifWNhr621kYrJwhfURsa0vFPeUEm8mF0ufg@mail.gmail.com/ > > Signed-off-by: Kees Cook <keescook@chromium.org> > --- > v4: > - fix another stray "void"! This is why code needs a compiler... (thx randy) > --- > Documentation/process/coding-style.rst | 30 ++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+)
Did I ever mention that I *hate* coding-style patches? :)
In this case I think we're as close as to consensus as things get. In the absence of a strong reason to the contrary, I'll apply this before too long.
Thanks,
jon
| |