Messages in this thread | | | From | Luca Weiss <> | Subject | Re: [PATCH 03/11] regulator: qcom-rpmh: Add PM6350 regulators | Date | Mon, 04 Oct 2021 22:44:25 +0200 |
| |
Hi Mark,
On Montag, 4. Oktober 2021 14:37:31 CEST Mark Brown wrote: > On Sun, Oct 03, 2021 at 10:31:26AM +0200, Luca Weiss wrote: > > Add the configuration for pm6350 regulators. The supplies are not known > > so use dummy ones for now. > > If you don't know don't fix it into ABI, just don't specify anything > until someone figures out something accurate to put in there. >
The RPMH_VREG macro expects _supply_name so what should I put there instead?
> > Additionally leave out configuration of smps3 - smps5 and ldo17 as these > > are not configured in the downstream kernel. > > Just describe everything that's there - nothing will get touched if the > board doesn't explicitly enable doing so, otherwise everything is read > only.
Problem is I do not know which types those regulators are, e.g. pldo or nldo. The ones I described are experimentally verified because the wrong configuration makes the driver probe fail. So I can't really put anything there, unless there's another way to do this.
Regards Luca
| |