Messages in this thread | | | Date | Mon, 4 Oct 2021 22:05:51 +0200 | From | Wolfram Sang <> | Subject | Re: [PATCH v2 07/14] mailbox: pcc: Use PCC mailbox channel pointer instead of standard |
| |
On Fri, Sep 17, 2021 at 02:33:50PM +0100, Sudeep Holla wrote: > Now that we have all the shared memory region information populated in > the pcc_mbox_chan, let us propagate the pointer to the same as the > return value to pcc_mbox_request channel. > > This eliminates the need for the individual users of PCC mailbox to > parse the PCCT subspace entries and fetch the shmem information. This > also eliminates the need for PCC mailbox controller to set con_priv to > PCCT subspace entries. This is required as con_priv is private to the > controller driver to attach private data associated with the channel and > not meant to be used by the mailbox client/users. > > Let us convert all the users of pcc_mbox_{request,free}_channel to use > new interface. > > Cc: Jean Delvare <jdelvare@suse.com> > Cc: Guenter Roeck <linux@roeck-us.net> > Cc: Wolfram Sang <wsa@kernel.org> > Cc: linux-hwmon@vger.kernel.org > Cc: linux-i2c@vger.kernel.org > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > --- > drivers/acpi/cppc_acpi.c | 43 ++++++------------ > drivers/hwmon/xgene-hwmon.c | 35 ++++++-------- > drivers/i2c/busses/i2c-xgene-slimpro.c | 33 +++++--------- > drivers/mailbox/pcc.c | 63 ++++++++------------------ > include/acpi/pcc.h | 12 ++---
There is no maintainer for the xgene driver, but I trust you and other reviewers of this whole series on this. The I2C part is a minor piece anyhow. So:
Acked-by: Wolfram Sang <wsa@kernel.org>
[unhandled content-type:application/pgp-signature] | |