lkml.org 
[lkml]   [2021]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [v3 PATCH 2/5] mm: filemap: check if THP has hwpoisoned subpage for PMD page fault
    On Mon, Oct 04, 2021 at 11:17:29AM -0700, Yang Shi wrote:
    > On Mon, Oct 4, 2021 at 7:06 AM Kirill A. Shutemov <kirill@shutemov.name> wrote:
    > >
    > > On Thu, Sep 30, 2021 at 02:53:08PM -0700, Yang Shi wrote:
    > > > diff --git a/mm/filemap.c b/mm/filemap.c
    > > > index dae481293b5d..2acc2b977f66 100644
    > > > --- a/mm/filemap.c
    > > > +++ b/mm/filemap.c
    > > > @@ -3195,12 +3195,12 @@ static bool filemap_map_pmd(struct vm_fault *vmf, struct page *page)
    > > > }
    > > >
    > > > if (pmd_none(*vmf->pmd) && PageTransHuge(page)) {
    > > > - vm_fault_t ret = do_set_pmd(vmf, page);
    > > > - if (!ret) {
    > > > - /* The page is mapped successfully, reference consumed. */
    > > > - unlock_page(page);
    > > > - return true;
    > > > - }
    > > > + vm_fault_t ret = do_set_pmd(vmf, page);
    > > > + if (!ret) {
    > > > + /* The page is mapped successfully, reference consumed. */
    > > > + unlock_page(page);
    > > > + return true;
    > > > + }
    > > > }
    > > >
    > > > if (pmd_none(*vmf->pmd)) {
    > >
    > > Hm. Is it unrelated whitespace fix?
    >
    > It is a coding style clean up. I thought it may be overkilling to have
    > a separate patch. Do you prefer separate one?

    Maybe. I tried to find what changed here. It's confusing.

    --
    Kirill A. Shutemov

    \
     
     \ /
      Last update: 2021-10-04 21:42    [W:2.272 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site