lkml.org 
[lkml]   [2021]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH rdma-next v2 08/13] RDMA/nldev: Allow optional-counter status configuration through RDMA netlink
On Thu, Sep 30, 2021 at 11:02:24AM +0300, Leon Romanovsky wrote:
> - if (nla_get_u32(tb[RDMA_NLDEV_ATTR_STAT_RES]) != RDMA_NLDEV_ATTR_RES_QP)
> - return -EINVAL;
> + target = kcalloc(BITS_TO_LONGS(stats->num_counters),
> + sizeof(long), GFP_KERNEL);
> + if (!target)
> + return -ENOMEM;

Same comment about the type here

This almost wants to be two patches to split up the set_doit then add
the new setter, it is hard to read..

Jason

\
 
 \ /
  Last update: 2021-10-04 20:03    [W:0.035 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site