Messages in this thread | | | Date | Mon, 4 Oct 2021 15:03:11 -0300 | From | Jason Gunthorpe <> | Subject | Re: [PATCH rdma-next v2 08/13] RDMA/nldev: Allow optional-counter status configuration through RDMA netlink |
| |
On Thu, Sep 30, 2021 at 11:02:24AM +0300, Leon Romanovsky wrote: > - if (nla_get_u32(tb[RDMA_NLDEV_ATTR_STAT_RES]) != RDMA_NLDEV_ATTR_RES_QP) > - return -EINVAL; > + target = kcalloc(BITS_TO_LONGS(stats->num_counters), > + sizeof(long), GFP_KERNEL); > + if (!target) > + return -ENOMEM;
Same comment about the type here
This almost wants to be two patches to split up the set_doit then add the new setter, it is hard to read..
Jason
| |