Messages in this thread | | | Date | Sun, 3 Oct 2021 14:54:56 +0100 | From | Matthew Wilcox <> | Subject | Re: [PATCH] mm/hugetlb.c: remove dead store in demote_size_show() |
| |
On Sun, Oct 03, 2021 at 06:41:13PM +0700, Nghia Le wrote: > { > struct hstate *h; > - unsigned long demote_size; > int nid; > > h = kobj_to_hstate(kobj, &nid); > - demote_size = h->demote_order; > > return sysfs_emit(buf, "%lukB\n", > (unsigned long)(PAGE_SIZE << h->demote_order) / SZ_1K);
I'd suggest this function would look better written as:
int nid; struct hstate *h = kobj_to_hstate(kobj, &nid); unsigned long demote_size = (PAGE_SIZE << h->demote_order) / SZ_1K;
return sysfs_emit(buf, "%lukB\n", demote_size);
| |