lkml.org 
[lkml]   [2021]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm/hugetlb.c: remove dead store in demote_size_show()
On Sun, Oct 03, 2021 at 06:41:13PM +0700, Nghia Le wrote:
> {
> struct hstate *h;
> - unsigned long demote_size;
> int nid;
>
> h = kobj_to_hstate(kobj, &nid);
> - demote_size = h->demote_order;
>
> return sysfs_emit(buf, "%lukB\n",
> (unsigned long)(PAGE_SIZE << h->demote_order) / SZ_1K);

I'd suggest this function would look better written as:

int nid;
struct hstate *h = kobj_to_hstate(kobj, &nid);
unsigned long demote_size = (PAGE_SIZE << h->demote_order) / SZ_1K;

return sysfs_emit(buf, "%lukB\n", demote_size);

\
 
 \ /
  Last update: 2021-10-03 15:57    [W:1.235 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site