lkml.org 
[lkml]   [2021]   [Oct]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH net-next] xdp: Remove redundant warning
    Date

    On 27/10/2021 03.38, Yajun Deng wrote:
    > There is a warning in xdp_rxq_info_unreg_mem_model() when reg_state isn't
    > equal to REG_STATE_REGISTERED, so the warning in xdp_rxq_info_unreg() is
    > redundant.
    >
    > Signed-off-by: Yajun Deng <yajun.deng@linux.dev>

    Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>

    I guess/wonder if we should mark this as a fix for:

    Fixes: dce5bd6140a4 ("xdp: export xdp_rxq_info_unreg_mem_model")

    > ---
    > net/core/xdp.c | 2 --
    > 1 file changed, 2 deletions(-)
    >
    > diff --git a/net/core/xdp.c b/net/core/xdp.c
    > index cc92ccb38432..5ddc29f29bad 100644
    > --- a/net/core/xdp.c
    > +++ b/net/core/xdp.c
    > @@ -143,8 +143,6 @@ void xdp_rxq_info_unreg(struct xdp_rxq_info *xdp_rxq)
    > if (xdp_rxq->reg_state == REG_STATE_UNUSED)
    > return;
    >
    > - WARN(!(xdp_rxq->reg_state == REG_STATE_REGISTERED), "Driver BUG");
    > -
    > xdp_rxq_info_unreg_mem_model(xdp_rxq);
    >
    > xdp_rxq->reg_state = REG_STATE_UNREGISTERED;
    >

    \
     
     \ /
      Last update: 2021-10-27 08:22    [W:3.533 / U:1.848 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site