Messages in this thread | | | Date | Wed, 27 Oct 2021 11:56:20 +0300 | Subject | Re: [PATCH] virtio-blk: select CONFIG_SG_POOL | From | Max Gurtovoy <> |
| |
This is strange, I've sent V3 with this code included.
MST,
which version did you take to your tree ?
On 10/27/2021 11:24 AM, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > Switching virtio-blk to the sg_pool interfaces causes a build > failures when they are not part of the kernel: > > drivers/block/virtio_blk.c:182:3: error: implicit declaration of function 'sg_free_table_chained' [-Werror,-Wimplicit-function-declaration] > sg_free_table_chained(&vbr->sg_table, > ^ > drivers/block/virtio_blk.c:195:8: error: implicit declaration of function 'sg_alloc_table_chained' [-Werror,-Wimplicit-function-declaration] > err = sg_alloc_table_chained(&vbr->sg_table, > ^ > > Select this symbol through Kconfig, as is done for all other > users. > > Fixes: b2c5221fd074 ("virtio-blk: avoid preallocating big SGL for data") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/block/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig > index d97eaf6adb6d..2a51dfb09c8f 100644 > --- a/drivers/block/Kconfig > +++ b/drivers/block/Kconfig > @@ -371,6 +371,7 @@ config XEN_BLKDEV_BACKEND > config VIRTIO_BLK > tristate "Virtio block driver" > depends on VIRTIO > + select SG_POOL > help > This is the virtual block driver for virtio. It can be used with > QEMU based VMMs (like KVM or Xen). Say Y or M.
| |