Messages in this thread | | | From | "Lad, Prabhakar" <> | Date | Tue, 26 Oct 2021 20:29:00 +0100 | Subject | Re: [RFC PATCH 2/4] pinctrl: pinconf-generic: Add support for "output-impedance" to be extracted from DT files |
| |
Hi Geert,
Thank you for the review.
On Thu, Oct 7, 2021 at 6:02 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Prabhakar, > > On Thu, Sep 30, 2021 at 2:17 PM Lad Prabhakar > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > Add "output-impedance" property to generic options used for DT parsing > > files. This enables drivers, which use generic pin configurations, to > > get the value passed to this property. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Thanks for your patch! > > > --- a/drivers/pinctrl/pinconf-generic.c > > +++ b/drivers/pinctrl/pinconf-generic.c > > @@ -46,6 +46,7 @@ static const struct pin_config_item conf_items[] = { > > PCONFDUMP(PIN_CONFIG_MODE_LOW_POWER, "pin low power", "mode", true), > > PCONFDUMP(PIN_CONFIG_OUTPUT_ENABLE, "output enabled", NULL, false), > > PCONFDUMP(PIN_CONFIG_OUTPUT, "pin output", "level", true), > > + PCONFDUMP(PIN_CONFIG_OUTPUT_IMPEDANCE, "output impedance", "ohm", true), > > PCONFDUMP(PIN_CONFIG_POWER_SOURCE, "pin power source", "selector", true), > > PCONFDUMP(PIN_CONFIG_SLEEP_HARDWARE_STATE, "sleep hardware state", NULL, false), > > PCONFDUMP(PIN_CONFIG_SLEW_RATE, "slew rate", NULL, true), > > @@ -179,6 +180,7 @@ static const struct pinconf_generic_params dt_params[] = { > > { "output-disable", PIN_CONFIG_OUTPUT_ENABLE, 0 }, > > { "output-enable", PIN_CONFIG_OUTPUT_ENABLE, 1 }, > > { "output-high", PIN_CONFIG_OUTPUT, 1, }, > > + { "output-impedance", PIN_CONFIG_OUTPUT_IMPEDANCE, 0 }, > > "output-impedance-ohms", as per DT standardized property units. > Sure will replace that with output-impedance-ohms and to chime in Ill re-name the macro to PIN_CONFIG_OUTPUT_IMPEDANCE_OHMS
Cheers, Prabhakar
> > { "output-low", PIN_CONFIG_OUTPUT, 0, }, > > { "power-source", PIN_CONFIG_POWER_SOURCE, 0 }, > > { "sleep-hardware-state", PIN_CONFIG_SLEEP_HARDWARE_STATE, 0 }, > > With the above fixed: > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
| |