Messages in this thread Patch in this message | | | From | Zhihao Cheng <> | Subject | [PATCH 08/11] ubifs: setflags: Don't make a budget for 'ui->data_len' | Date | Mon, 25 Oct 2021 11:41:13 +0800 |
| |
'setflags()' affects regular files and directories, only xattr inode, symlink inode and special inode(pipe/char_dev/block_dev) have none- zero 'ui->data_len' field.
Remove superfluous space budget for 'dirtied_ino_d', besides add an assert to verify that 'setflags()' only operates ubifs inode with zero data_len.
Fixes: 1e51764a3c2ac05a ("UBIFS: add new flash file system") Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com> --- fs/ubifs/ioctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ubifs/ioctl.c b/fs/ubifs/ioctl.c index c6a863487780..ed95e97a3740 100644 --- a/fs/ubifs/ioctl.c +++ b/fs/ubifs/ioctl.c @@ -107,9 +107,9 @@ static int setflags(struct inode *inode, int flags) int err, release; struct ubifs_inode *ui = ubifs_inode(inode); struct ubifs_info *c = inode->i_sb->s_fs_info; - struct ubifs_budget_req req = { .dirtied_ino = 1, - .dirtied_ino_d = ui->data_len }; + struct ubifs_budget_req req = { .dirtied_ino = 1 }; + ubifs_assert(c, !ui->data_len); err = ubifs_budget_space(c, &req); if (err) return err; -- 2.31.1
| |