Messages in this thread | | | From | Shakeel Butt <> | Date | Tue, 19 Oct 2021 08:56:26 -0700 | Subject | Re: [PATCH v2 1/2] mm/vmalloc: fix numa spreading for large hash tables |
| |
On Mon, Oct 18, 2021 at 5:23 AM Chen Wandun <chenwandun@huawei.com> wrote: > [...] > > /* High-order pages or fallback path if "bulk" fails. */ > - while (nr_allocated < nr_pages) { > - struct page *page; > - int i; > > - page = alloc_pages_node(nid, gfp, order); > + page = NULL;
No need for the above NULL assignment.
After removing this, you can add:
Reviewed-by: Shakeel Butt <shakeelb@google.com>
> + while (nr_allocated < nr_pages) { > + if (nid == NUMA_NO_NODE) > + page = alloc_pages(gfp, order); > + else > + page = alloc_pages_node(nid, gfp, order); > if (unlikely(!page)) > break; > > -- > 2.25.1 >
| |