Messages in this thread | | | Subject | Re: [PATCH v2 04/21] perf pmu: Make pmu_event tables const. | From | John Garry <> | Date | Tue, 19 Oct 2021 12:19:24 +0100 |
| |
On 15/10/2021 18:21, Ian Rogers wrote:
- bouncing Changbin Du <changbin.du@intel.com> and Jin Yao <yao.jin@linux.intel.com>
> Make lookup nature of data structures clearer through their type. Reduce > scope of architecture specific pmu_event tables by making them static. > > Suggested-by: John Garry<john.garry@huawei.com> > Acked-by: Andi Kleen<ak@linux.intel.com> > Signed-off-by: Ian Rogers<irogers@google.com>
Reviewed-by: John Garry <john.garry@huawei.com>
BTW, We seem to be using > 80 char per line now. Well in metricgroup.h anyway, from a brief check. I know checkpatch.pl is ok with this now, but some maintainers aren't. Just saying.
Thanks, John
| |