lkml.org 
[lkml]   [2021]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 -next 2/2] blk-cgroup: synchoronize blkg creation against policy deactivation
Hello,

Some nitpicks.

On Tue, Oct 19, 2021 at 10:41:32AM +0800, Yu Kuai wrote:
...
> Because blkcg_deactivate_policy() require queue to be freezed, thus grab
^ ^ ^
requires frozen we can grab

> q_usage_counter to synchoronize blkg_conf_prep() against
> blkcg_deactivate_policy().
...
> + /*
> + * blkcg_deactivate_policy() require queue to be freezed, thus grab
> + * q_usage_counter to prevent concurrent with blkcg_deactivate_policy().
> + */

Same here.

Looks good otherwise. Please feel free to add

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

--
tejun

\
 
 \ /
  Last update: 2021-10-19 19:04    [W:0.039 / U:3.988 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site