lkml.org 
[lkml]   [2021]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 15/50] cb710: avoid NULL pointer subtraction
    Date
    From: Arnd Bergmann <arnd@arndb.de>

    commit 42641042c10c757fe10cc09088cf3f436cec5007 upstream.

    clang-14 complains about an unusual way of converting a pointer to
    an integer:

    drivers/misc/cb710/sgbuf2.c:50:15: error: performing pointer subtraction with a null pointer has undefined behavior [-Werror,-Wnull-pointer-subtraction]
    return ((ptr - NULL) & 3) != 0;

    Replace this with a normal cast to uintptr_t.

    Fixes: 5f5bac8272be ("mmc: Driver for CB710/720 memory card reader (MMC part)")
    Cc: stable <stable@vger.kernel.org>
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Link: https://lore.kernel.org/r/20210927121408.939246-1-arnd@kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/misc/cb710/sgbuf2.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/misc/cb710/sgbuf2.c
    +++ b/drivers/misc/cb710/sgbuf2.c
    @@ -50,7 +50,7 @@ static inline bool needs_unaligned_copy(
    #ifdef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS
    return false;
    #else
    - return ((ptr - NULL) & 3) != 0;
    + return ((uintptr_t)ptr & 3) != 0;
    #endif
    }


    \
     
     \ /
      Last update: 2021-10-18 15:31    [W:2.162 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site