lkml.org 
[lkml]   [2021]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 31/39] nfc: fix error handling of nfc_proto_register()
    Date
    From: Ziyang Xuan <william.xuanziyang@huawei.com>

    commit 0911ab31896f0e908540746414a77dd63912748d upstream.

    When nfc proto id is using, nfc_proto_register() return -EBUSY error
    code, but forgot to unregister proto. Fix it by adding proto_unregister()
    in the error handling case.

    Fixes: c7fe3b52c128 ("NFC: add NFC socket family")
    Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com>
    Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
    Link: https://lore.kernel.org/r/20211013034932.2833737-1-william.xuanziyang@huawei.com
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/nfc/af_nfc.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/net/nfc/af_nfc.c
    +++ b/net/nfc/af_nfc.c
    @@ -72,6 +72,9 @@ int nfc_proto_register(const struct nfc_
    proto_tab[nfc_proto->id] = nfc_proto;
    write_unlock(&proto_tab_lock);

    + if (rc)
    + proto_unregister(nfc_proto->proto);
    +
    return rc;
    }
    EXPORT_SYMBOL(nfc_proto_register);

    \
     
     \ /
      Last update: 2021-10-18 15:29    [W:3.614 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site