Messages in this thread | | | Date | Mon, 18 Oct 2021 12:04:37 +0200 | Subject | Re: [PATCH 3/6] drm: vkms: Replace hardcoded value of `vkms_composer.map` to DRM_FORMAT_MAX_PLANES | From | Thomas Zimmermann <> |
| |
Hi
Am 05.10.21 um 22:16 schrieb Igor Matheus Andrade Torrente: > The `map` vector at `vkms_composer` uses a hardcoded value to define its > size. > > If someday the maximum number of planes increases, this hardcoded value > can be a problem. > > This value is being replaced with the DRM_FORMAT_MAX_PLANES macro. > > Signed-off-by: Igor Matheus Andrade Torrente <igormtorrente@gmail.com> > --- > drivers/gpu/drm/vkms/vkms_drv.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vkms/vkms_drv.h b/drivers/gpu/drm/vkms/vkms_drv.h > index d48c23d40ce5..64e62993b06f 100644 > --- a/drivers/gpu/drm/vkms/vkms_drv.h > +++ b/drivers/gpu/drm/vkms/vkms_drv.h > @@ -28,7 +28,7 @@ struct vkms_writeback_job { > struct vkms_composer { > struct drm_framebuffer fb; > struct drm_rect src, dst; > - struct dma_buf_map map[4]; > + struct dma_buf_map map[DRM_FORMAT_MAX_PLANES];
I suspect that I simply missed this instance while introducing DRM_FORMAT_MAX_PLANES. Thanks for fixing.
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
> unsigned int offset; > unsigned int pitch; > unsigned int cpp; >
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer [unhandled content-type:application/pgp-signature] | |