lkml.org 
[lkml]   [2021]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv3 0/4] Get rid of pm_runtime_irq_safe() for 8250_omap
On Fri, Oct 15, 2021 at 02:26:22PM +0300, Tony Lindgren wrote:
> Hi,
>
> Here are v3 patches to get rid of pm_runtime_irq_safe() for the 8250_omap
> driver. Based on comments from Andy, Johan and Greg, I improved a bunch of
> things as listed below.
>
> For removing the pm_runtime_irq_safe() usage, serial TX is the last
> remaining issue. We deal with TX by waking up the port and returning 0
> bytes written from write_room() and write() if the port is not available
> because of PM runtime autoidle.

Oh, there's a lot more than TX that needs fixing... And I believe the
second sentence no longer applies since v1.

> Chganges since v2:
>
> - Use locking instead of atomic_t as suggested by Greg
>
> Changes since v1:
>
> - Separated out line discipline patches, n_tty -EAGAIN change I still
> need to retest
>
> - Changed prep_tx() to more generic wakeup() as also flow control needs it
>
> - Changed over to using wakeup() with device driver runtime PM instead
> of write_room()
>
> - Added runtime_suspended flag for drivers and generic serial layer PM
> to use

Johan

\
 
 \ /
  Last update: 2021-10-18 09:12    [W:0.368 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site