lkml.org 
[lkml]   [2021]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] scsi: qla2xxx: Return -ENOMEM if kzalloc() fails
Date


> On Oct 17, 2021, at 8:56 PM, Zheyu Ma <zheyuma97@gmail.com> wrote:
>
> During the process of driver probing, probe function should return < 0
> for failure, otherwise kernel will treat value > 0 as success.
>
> Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
> ---
> drivers/scsi/qla2xxx/qla_os.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
> index d2e40aaba734..836fedcea241 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -4157,7 +4157,7 @@ qla2x00_mem_alloc(struct qla_hw_data *ha, uint16_t req_len, uint16_t rsp_len,
> ql_dbg_pci(ql_dbg_init, ha->pdev,
> 0xe0ee, "%s: failed alloc dsd\n",
> __func__);
> - return 1;
> + return -ENOMEM;
> }
> ha->dif_bundle_kallocs++;
>
> --
> 2.17.6
>

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

--
Himanshu Madhani Oracle Linux Engineering

\
 
 \ /
  Last update: 2021-10-18 16:21    [W:1.379 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site