Messages in this thread | | | Subject | Re: [PATCH 1/2] mm/damon/vaddr: constify static mm_walk_ops | From | Anshuman Khandual <> | Date | Mon, 18 Oct 2021 12:19:36 +0530 |
| |
On 10/14/21 1:20 PM, Rikard Falkeborn wrote: > The only usage of these structs is to pass their addresses to > walk_page_range(), which takes a pointer to const mm_walk_ops as > argument. Make them const to allow the compiler to put them in > read-only memory. > > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> > --- > mm/damon/vaddr.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c > index 953c145b4f08..65d4f115fa66 100644 > --- a/mm/damon/vaddr.c > +++ b/mm/damon/vaddr.c > @@ -476,7 +476,7 @@ static int damon_mkold_pmd_entry(pmd_t *pmd, unsigned long addr, > return 0; > } > > -static struct mm_walk_ops damon_mkold_ops = { > +static const struct mm_walk_ops damon_mkold_ops = { > .pmd_entry = damon_mkold_pmd_entry, > }; > > @@ -572,7 +572,7 @@ static int damon_young_pmd_entry(pmd_t *pmd, unsigned long addr, > return 0; > } > > -static struct mm_walk_ops damon_young_ops = { > +static const struct mm_walk_ops damon_young_ops = { > .pmd_entry = damon_young_pmd_entry, > }; > >
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
| |