Messages in this thread | | | Date | Sun, 17 Oct 2021 12:37:08 +0200 | From | Marc Kleine-Budde <> | Subject | Re: [PATCH net] can: j1939: j1939_xtp_rx_rts_session_new(): abort TP less than 9 bytes |
| |
On 14.10.2021 17:26:40, Zhang Changzhong wrote: > The receiver should abort TP if 'total message size' in TP.CM_RTS and > TP.CM_BAM is less than 9 or greater than 1785 [1], but currently the > j1939 stack only checks the upper bound and the receiver will accept the > following broadcast message: > vcan1 18ECFF00 [8] 20 08 00 02 FF 00 23 01 > vcan1 18EBFF00 [8] 01 00 00 00 00 00 00 00 > vcan1 18EBFF00 [8] 02 00 FF FF FF FF FF FF > > This patch adds check for the lower bound and abort illegal TP. > > [1] SAE-J1939-82 A.3.4 Row 2 and A.3.6 Row 6. > > Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol") > Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Applied to linux-can/testing, added stable on Cc.
regards, Marc
-- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | [unhandled content-type:application/pgp-signature] | |