lkml.org 
[lkml]   [2021]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Input: cpcap-pwrbutton - do not set input parent explicitly
Hi,

On Fri, Oct 15, 2021 at 10:25:58PM -0700, Dmitry Torokhov wrote:
> We are using devm_input_allocate_device() that already sets parent
> of the input device, there is no need to do that again.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>

-- Sebastian

> drivers/input/misc/cpcap-pwrbutton.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/misc/cpcap-pwrbutton.c b/drivers/input/misc/cpcap-pwrbutton.c
> index 372cb44d0635..879790bbf9fe 100644
> --- a/drivers/input/misc/cpcap-pwrbutton.c
> +++ b/drivers/input/misc/cpcap-pwrbutton.c
> @@ -77,7 +77,6 @@ static int cpcap_power_button_probe(struct platform_device *pdev)
>
> button->idev->name = "cpcap-pwrbutton";
> button->idev->phys = "cpcap-pwrbutton/input0";
> - button->idev->dev.parent = button->dev;
> input_set_capability(button->idev, EV_KEY, KEY_POWER);
>
> err = devm_request_threaded_irq(&pdev->dev, irq, NULL,
> --
> 2.33.0.1079.g6e70778dc9-goog
>
>
> --
> Dmitry
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-10-16 18:04    [W:0.045 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site