Messages in this thread | | | Subject | Re: [PATCH 7/8] watchdog: max77714: add driver for the watchdog in the MAX77714 PMIC | From | Randy Dunlap <> | Date | Fri, 15 Oct 2021 10:07:26 -0700 |
| |
On 10/15/21 9:42 AM, Luca Ceresoli wrote: > Hi, > > On 12/10/21 03:18, Randy Dunlap wrote: >> Hi, >> >> On 10/11/21 8:56 AM, Luca Ceresoli wrote: >>> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig >>> index bf59faeb3de1..00bc3f932a6c 100644 >>> --- a/drivers/watchdog/Kconfig >>> +++ b/drivers/watchdog/Kconfig >>> @@ -699,6 +699,15 @@ config MAX77620_WATCHDOG >>> MAX77620 chips. To compile this driver as a module, >>> choose M here: the module will be called max77620_wdt. >>> +config MAX77714_WATCHDOG >>> + tristate "Maxim MAX77714 Watchdog Timer" >>> + depends on MFD_MAX77714 || COMPILE_TEST >>> + help >>> + This is the driver for watchdog timer in the MAX77714 PMIC. >>> + Say 'Y' here to enable the watchdog timer support for >>> + MAX77714 chips. To compile this driver as a module, >>> + choose M here: the module will be called max77714_wdt. >> >> Please follow coding-style for Kconfig files: >> >> (from Documentation/process/coding-style.rst, section 10): >> >> For all of the Kconfig* configuration files throughout the source tree, >> the indentation is somewhat different. Lines under a ``config`` definition >> are indented with one tab, while help text is indented an additional two >> spaces. > > Oh dear, I usually don't make such silly mistakes, apologies. > > [...some fast typing later...] > > Uhm, now I noticed many entries in that file have that same mistake. > Perhaps I copy-pasted and didn't check. I'll send a patch to fix them too. >
Thanks. :)
-- ~Randy
| |