Messages in this thread | | | Subject | Re: [PATCH v4 03/13] memory: mtk-smi: Use clk_bulk clock ops | From | AngeloGioacchino Del Regno <> | Date | Fri, 15 Oct 2021 15:38:40 +0200 |
| |
> Use clk_bulk interface instead of the orginal one to simplify the code. > > For SMI larbs: Require apb/smi clocks while gals is optional. > For SMI common: Require apb/smi/gals0/gal1 in has_gals case. Otherwise, > also only require apb/smi, No optional clk here. > > About the "has_gals" flag, for smi larbs, the gals clock also may be > optional even this platform support it. thus it always use > *_bulk_get_optional, then the flag has_gals is unnecessary. Remove it. > The smi_common's has_gals still keep it. > > Also remove clk fail logs since bulk interface already output fail log. > > Signed-off-by: Yong Wu <yong.wu@mediatek.com>
Hello Yong, thanks for the patch! However, I have an improvement to point out:
> --- > drivers/memory/mtk-smi.c | 143 +++++++++++++++------------------------ > 1 file changed, 55 insertions(+), 88 deletions(-) > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > index c5fb51f73b34..f91eaf5c3ab0 100644 > --- a/drivers/memory/mtk-smi.c > +++ b/drivers/memory/mtk-smi.c > @@ -60,6 +60,20 @@ enum mtk_smi_gen { > MTK_SMI_GEN2 > }; > > +#define MTK_SMI_CLK_NR_MAX 4
This refers to mtk_smi_common_clks[] and should be probably moved after that. In any case, I don't think that there's any need to manually define this as 4, as you can simply use the macro ARRAY_SIZE(mtk_smi_common_clks). Using that will make you able to not update this definition everytime an update occurs to the mtk_smi_common_clks array.
> + > +/* larbs: Require apb/smi clocks while gals is optional. */ > +static const char * const mtk_smi_larb_clks[] = {"apb", "smi", "gals"}; > +#define MTK_SMI_LARB_REQ_CLK_NR 2 > +#define MTK_SMI_LARB_OPT_CLK_NR 1 > + > +/* > + * common: Require these four clocks in has_gals case. Otherwise, only apb/smi are required. > + */ > +static const char * const mtk_smi_common_clks[] = {"apb", "smi", "gals0", "gals1"}; > +#define MTK_SMI_COM_REQ_CLK_NR 2 > +#define MTK_SMI_COM_GALS_REQ_CLK_NR MTK_SMI_CLK_NR_MAX > +
Apart from that, Acked-By: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Regards, - Angelo
| |