lkml.org 
[lkml]   [2021]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] staging: r8188eu: remove MSG_88E calls from hal/usb_halinit.c
From
On 10/15/21 02:02, Phillip Potter wrote:
> Remove both MSG_88E calls from hal/usb_halinit.c, as these calls serve
> no purpose other than to print the name of the function they are in
> (_ReadAdapterInfo8188EU) on entry and on exit, with a timing of the
> function, which is better accomplished by other means. Also remove
> the jiffies assignment at the start of the function, as it is no
> longer used.
>
> Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> ---
> drivers/staging/r8188eu/hal/usb_halinit.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c
> index f6db5b05e6e7..abbd107ad3c1 100644
> --- a/drivers/staging/r8188eu/hal/usb_halinit.c
> +++ b/drivers/staging/r8188eu/hal/usb_halinit.c
> @@ -1073,15 +1073,9 @@ static void _ReadRFType(struct adapter *Adapter)
>
> static int _ReadAdapterInfo8188EU(struct adapter *Adapter)
> {
> - u32 start = jiffies;
> -
> - MSG_88E("====> %s\n", __func__);
> -
> _ReadRFType(Adapter);/* rf_chip -> _InitRFType() */
> _ReadPROMContent(Adapter);
>
> - MSG_88E("<==== %s in %d ms\n", __func__, rtw_get_passing_time_ms(start));
> -
> return _SUCCESS;
> }
>
>

Looks good to me.

Acked-by: Michael Straube <straube.linux@gmail.com>

Thanks,
Michael

\
 
 \ /
  Last update: 2021-10-15 09:56    [W:0.167 / U:0.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site