Messages in this thread | | | From | Guo Ren <> | Date | Thu, 14 Oct 2021 14:17:24 +0800 | Subject | Re: [PATCH V3 1/2] dt-bindings: update riscv plic compatible string |
| |
On Thu, Oct 14, 2021 at 12:21 PM Samuel Holland <samuel@sholland.org> wrote: > > On 10/13/21 7:49 AM, Guo Ren wrote: > >>>>>>>> - const: sifive,plic-1.0.0 > >>>>>>> > >>>>>>> The PLIC DT node requires two compatible string: > >>>>>>> <implementation_compat>, <spec_compat> > >>>>>>> > >>>>>>> The C9xx PLIC is not RISC-V PLIC so, the DT node should > >>>>>>> be: "thead,c900-plic", "thead,c9xx-plic" > >>>>>>> > >>>>>>> You need to change "- const: sifive,plic-1.0.0" to > >>>>>>> - enum: > >>>>>>> - sifive,plic-1.0.0 > >>>>>>> - thead,c9xx-plic > >> > >> isn't XuanTie the series containing the c906 and c910? > > XuanTie contain two CPU series: > > riscv: c906, c910 > > csky: c807, c810, c860 > > > >> So maybe > >> thead,xuantie-plic > >> for the spec compatible. > >> > >> So doing in full > >> compatible = "thead,c906-plic", "thead,xuantie-plic" > > How about: > > compatible = "allwinner,d1-plic", "thead,c900-plic" > > To follow the <family>-<soc>-<device> pattern of existing Allwinner > compatibles, the first string should be "allwinner,sun20i-d1-plic". Thx, Got it. > Otherwise, this looks to me like the right thing to do. > > Regards, > Samuel
-- Best Regards Guo Ren
ML: https://lore.kernel.org/linux-csky/
| |