lkml.org 
[lkml]   [2021]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 4/5] PCI/switchtec: Replace ENOTSUPP with EOPNOTSUPP
[+cc Jakub for visibility]

Hi,

> ENOTSUPP is not a SUSV4 error code, and the following checkpatch.pl
> warning will be given for new patches which still use ENOTSUPP.
>
> WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP
>
> See the link below for the discussion.
>
> https://lore.kernel.org/netdev/20200511165319.2251678-1-kuba@kernel.org/

This makes me wonder whether we should fix other occurrences of ENOTSUPP we
have in the PCI tree, as per:

Index File Line Content
0 drivers/pci/msi.c 1304 * -ENOTSUPP otherwise
1 drivers/pci/msi.c 1316 return -ENOTSUPP;
2 drivers/pci/pcie/dpc.c 355 return -ENOTSUPP;
3 drivers/pci/setup-res.c 421 return -ENOTSUPP;
4 drivers/pci/setup-res.c 433 return -ENOTSUPP;
5 drivers/pci/pci.c 3600 * Returns -ENOTSUPP if resizable BARs are not supported at all.
6 drivers/pci/pci.c 3610 return -ENOTSUPP;
7 drivers/pci/switch/switchtec.c 330 return -ENOTSUPP; \
8 drivers/pci/switch/switchtec.c 616 return -ENOTSUPP;
9 drivers/pci/switch/switchtec.c 824 return -ENOTSUPP;
10 drivers/pci/switch/switchtec.c 1559 return -ENOTSUPP;
11 drivers/pci/controller/dwc/pcie-tegra194.c 2244 return -ENOTSUPP;

What do you think Bjorn? Jakub?

Krzysztof

\
 
 \ /
  Last update: 2021-10-15 03:56    [W:0.157 / U:0.620 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site