Messages in this thread | | | Date | Thu, 14 Oct 2021 11:47:01 -0700 | From | Kees Cook <> | Subject | Re: [PATCH v5 09/15] x86: Use an opaque type for functions not callable from C |
| |
On Thu, Oct 14, 2021 at 07:31:26PM +0200, Borislav Petkov wrote: > On Thu, Oct 14, 2021 at 09:07:57AM -0700, Kees Cook wrote: > Looking at the changelog, DECLARE_ASM_FUNC_SYMBOL, makes a lot more > sense to me even if it doesn't specify the aspect that it is not called > by C but who cares - it is generic enough.
Around we go. :) Josh[1] and Steven[2] explicitly disagreed with that name, leading to the current name[3]. Do you want it to be DECLARE_ASM_FUNC_SYMBOL() over those objections?
I'd really like to finish this shed -- I need to take the bikes in from the rain. :P
-Kees
[1] https://lore.kernel.org/lkml/20211006032945.axlqh3vehgar6adr@treble/ [2] https://lore.kernel.org/lkml/20211006101654.6a5be402@gandalf.local.home/ [3] https://lore.kernel.org/lkml/CABCJKufCaOXOUF43a-PQshO8aEsMNhZ2EiyGMSOp9ZGn57G=pg@mail.gmail.com/
-- Kees Cook
| |