lkml.org 
[lkml]   [2021]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 3/7] i2c: i2c-amd-mp2-plat: ACPI: Use ACPI_COMPANION() directly
    Date
    From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

    The ACPI_HANDLE() macro is a wrapper arond the ACPI_COMPANION()
    macro and the ACPI handle produced by the former comes from the
    ACPI device object produced by the latter, so it is way more
    straightforward to evaluate the latter directly instead of passing
    the handle produced by the former to acpi_bus_get_device().

    Modify i2c_amd_probe() accordingly (no intentional functional impact).

    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Acked-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
    ---

    v1 -> v2:
    * Resend with a different From and S-o-b address and with maintainer ACK.
    No other changes.

    ---
    drivers/i2c/busses/i2c-amd-mp2-plat.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    Index: linux-pm/drivers/i2c/busses/i2c-amd-mp2-plat.c
    ===================================================================
    --- linux-pm.orig/drivers/i2c/busses/i2c-amd-mp2-plat.c
    +++ linux-pm/drivers/i2c/busses/i2c-amd-mp2-plat.c
    @@ -246,12 +246,11 @@ static int i2c_amd_probe(struct platform
    {
    int ret;
    struct amd_i2c_dev *i2c_dev;
    - acpi_handle handle = ACPI_HANDLE(&pdev->dev);
    - struct acpi_device *adev;
    + struct acpi_device *adev = ACPI_COMPANION(&pdev->dev);
    struct amd_mp2_dev *mp2_dev;
    const char *uid;

    - if (acpi_bus_get_device(handle, &adev))
    + if (!adev)
    return -ENODEV;

    /* The ACPI namespace doesn't contain information about which MP2 PCI


    \
     
     \ /
      Last update: 2021-10-13 18:17    [W:4.167 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site