Messages in this thread | | | Date | Wed, 13 Oct 2021 11:09:59 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH v2] tracing: Fix event probe removal from dynamic events |
| |
On Wed, 13 Oct 2021 23:32:44 +0900 Masami Hiramatsu <mhiramat@kernel.org> wrote:
> > Then the following should work: > > > > # echo '-:hrstate timer/hrtimer_cancel state=+0x38($hrtimer):u8' >> dynamic_events > > # echo '-:eprobes/hrstate timer.hrtimer_cancel state=+0x38($hrtimer):u8' >> dynamic_events > > # echo '-:eprobes/hrstate timer.hrtimer_cancel' >> dynamic_events > > # echo '-:eprobes/hrstate' >> dynamic_events > > Agreed. > > > > > But the following will not work: > > > > # echo '-:hrstate state=+0x38($hrtimer):u8' >> dynamic_events > > # echo '-:hrstate timer.hrtimer_cancel state=+0x38($hrtimer):u8' >> dynamic_events > > # echo '-:hrstate timer.hrtimer_cancel' >> dynamic_events > > The first one is agreed. But the rest 2 cases should work because it just omits the > group name. At least {k,u}probe events work. > > > Should this work? > > > > # echo '-:hrstate' >> dynamic_events > > Yes. In this case, all dynamic events which have "hrstate" event name are removed.
Thanks for the feedback. I'll update it.
-- Steve
| |