lkml.org 
[lkml]   [2021]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] PCI: apple: select CONFIG_PCI_HOST_COMMON
On Wed, Oct 13, 2021 at 04:38:50PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> If this symbol is not already selected by another driver, pci-apple.o
> fails to link:
>
> aarch64-linux-ld: drivers/pci/controller/pcie-apple.o: in function `apple_pcie_probe':
> pcie-apple.c:(.text+0xd28): undefined reference to `pci_host_common_probe'
>
> Add another 'select' statement here, the same that is used for the
> other drivers.
>
> Fixes: a8bbe0366a3e ("PCI: apple: Add initial hardware bring-up")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/pci/controller/Kconfig | 1 +
> 1 file changed, 1 insertion(+)

Squashed it in the commit it is fixing and rebuilt my pci/apple
branch.

Thanks,
Lorenzo

>
> diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
> index cc1fcc89c58f..5af99701e1f6 100644
> --- a/drivers/pci/controller/Kconfig
> +++ b/drivers/pci/controller/Kconfig
> @@ -322,6 +322,7 @@ config PCIE_APPLE
> depends on ARCH_APPLE || COMPILE_TEST
> depends on OF
> depends on PCI_MSI_IRQ_DOMAIN
> + select PCI_HOST_COMMON
> help
> Say Y here if you want to enable PCIe controller support on Apple
> system-on-chips, like the Apple M1. This is required for the USB
> --
> 2.29.2
>

\
 
 \ /
  Last update: 2021-10-13 17:02    [W:0.032 / U:1.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site