lkml.org 
[lkml]   [2021]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v3 9/9] PCI: imx: add the imx8mm pcie support
    From
    Date
    On Tue, 2021-10-12 at 16:41 +0800, Richard Zhu wrote:
    > i.MX8MM PCIe works mostly like the i.MX8MQ one, but has a different PHY
    > and allows to output the internal PHY reference clock via the refclk pad.
    > Add the i.MX8MM PCIe support based on the standalone PHY driver.
    >
    > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
    > ---
    > [...]
    > @@ -1130,6 +1176,14 @@ static int imx6_pcie_probe(struct platform_device *pdev)
    > &imx6_pcie->tx_swing_low))
    > imx6_pcie->tx_swing_low = 127;
    >
    > + /* get PHY refclk pad mode if there is PHY node */
    > + phy_node = of_parse_phandle(node, "phys", 0);
    > + if (phy_node) {
    > + of_property_read_u32(phy_node, "fsl,refclk-pad-mode",
    > + &imx6_pcie->refclk_pad_mode);

    It seems to me that the refclk_pad_mode is not actually used by this
    driver anymore, because it is handled by the PHY driver now. Is there a
    reason to read this property here at all?


    \
     
     \ /
      Last update: 2021-10-13 14:46    [W:4.075 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site