Messages in this thread | | | Subject | Re: [PATCH net 1/2] NFC: digital: fix possible memory leak in digital_tg_listen_mdaa() | From | Krzysztof Kozlowski <> | Date | Wed, 13 Oct 2021 11:35:03 +0200 |
| |
On 13/10/2021 09:50, Ziyang Xuan wrote: > 'params' is allocated in digital_tg_listen_mdaa(), but not free when > digital_send_cmd() failed, which will cause memory leak. Fix it by > freeing 'params' if digital_send_cmd() return failed. > > Fixes: 1c7a4c24fbfd ("NFC Digital: Add target NFC-DEP support") > Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com> > --- > net/nfc/digital_core.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) >
Good catch. Leak is only theoretical as digital_send_cmd() will fail only on memory allocation failure but your fix makes code correct.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards, Krzysztof
| |