lkml.org 
[lkml]   [2021]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] sched/fair: Use rq->lock when checking cfs_rq list presence
Hi,

tir. 12. okt. 2021 kl. 19:31 skrev Tao Zhou <tao.zhou@linux.dev>:
>
> Er.. this is considered specific to this fix I think. Normal unthrottle(not
> race with delete, avg maybe used in after) also need the normal avg decay.

Yeah, it was more meant as a way to express my idea, should probably have
said that more explicitly. It would essentially be a revert of a7b359fc6a37
("sched/fair: Correctly insert cfs_rq's to list on unthrottle"),
while "temporary" fixing the problem it fixed, by removing the load from the tg.

But yeah, it would still need to decay the load properly to _actually_ be fully
correct and work as it does today. But in most cases nr_running>0 on unthrottle,
but yeah, it is definitely not always the case.

Thanks
Odin

\
 
 \ /
  Last update: 2021-10-13 20:53    [W:0.079 / U:1.860 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site